[pve-devel] qemu-server : implement pending changes v2

[Alexandre DERUMIER]

>>Some questions regarding this patch:
>>- What happens when we do online migration with pending changes?

pending changes not applied.
(Currently if you do a change a non-hotpluggage value and you do a live migration, you have good chance to crash)



>>- What happens when we do online migration with pending changes and VM
>>crashes for some reason? Will changes be applied on start?
>>- What happens when a machine has pending changes, then it crashes and
>>starts by HA on another node? Will changes be applied on start?

Yes, I have planned to apply pending change on vm_stop and vm_start (in case on unclean stop)

Another way could be to add a button to apply manually the pending change. (Don't known what is the best way)




----- Mail original ----- 

De: "Stanislav German-Evtushenko" <ginermail at gmail.com> 
À: pve-devel at pve.proxmox.com, "Alexandre Derumier" <aderumier at odiso.com> 
Envoyé: Jeudi 30 Octobre 2014 17:11:37 
Objet: Re: [pve-devel] qemu-server : implement pending changes v2 

> Date: Thu, 30 Oct 2014 13:40:21 +0100 
> From: Alexandre Derumier <aderumier at odiso.com> 
> To: pve-devel at pve.proxmox.com 
> Subject: [pve-devel] qemu-server : implement pending changes v2 
> Message-ID: <1414672833-17829-1-git-send-email-aderumier at odiso.com> 
> 
> Hi, 
> 
> I have redone my patch with Diemar recommendations, 
> 
> main difference: 
> 
> -pending delete are now in a delete list 
> 
> delete: virtio0,net0 
> 
> -no more unused disk in pending conf 
> 
> 
> I have splitted my big patch into many smaller 
> (I hope that nothing is missing, but I have redone tests everywhere and all seem to working file). 


Hi, 

Some questions regarding this patch: 
- What happens when we do online migration with pending changes? 
- What happens when we do online migration with pending changes and VM 
crashes for some reason? Will changes be applied on start? 
- What happens when a machine has pending changes, then it crashes and 
starts by HA on another node? Will changes be applied on start? 

Best regards, 
Stanislav German-Evtushenko