[pve-devel] [PATCH 2/6] vmconfig_hotplug_pending : add update_net

[Alexandre DERUMIER]

>>Yes, right. But only if the vm is not migrated. So I guess you need to prevent that 
>>if $migratedfrom is set? 

Oh, yes, indeed, you are right, I totaly miss this case.

----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 17 Novembre 2014 17:25:54 
Objet: RE: [pve-devel] [PATCH 2/6] vmconfig_hotplug_pending : add update_net 

> >>Note: you always use the value from [PENDING] inside pve-bridge 
> 
> if ($conf->{pending}->{$netid}){ 
> $conf = $conf->{pending}; 
> } 
> 
> So, yes, I always use the pending conf if it's exist, in case we want to hotplug it. 
> 
> But, on vm start, I think the pending conf is already removed right ? 

Yes, right. But only if the vm is not migrated. So I guess you need to prevent that 
if $migratedfrom is set? 

if ($conf->{pending}->{$netid} && !defined($migratedfrom)){ 
$conf = $conf->{pending}; 
}