[pve-devel] [PATCH 2/6] vmconfig_hotplug_pending : add update_net

[Alexandre DERUMIER]

>>What is someone wants:
>>
>>hotplug: 0
>>
>>Then you want to keep changes in [PENDING], without applying them.

yes, exactly. That's the way my patches are working.

hot-unplug
------
[CONF]
virtio0:....
hotplug:0


qm set 110 -delete virtio0

[CONF]
virtio0:....
hotplug:0
[PENDING]
delete: virtio0



hotplug
--------
[CONF]
hotplug:0

qm set 110 -virtio0 local:1

[CONF]
hotplug:0
[PENDING]
virtio0: ....





----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 17 Novembre 2014 17:05:48 
Objet: RE: [pve-devel] [PATCH 2/6] vmconfig_hotplug_pending : add update_net 

> >>THis looks also problematic. What if someone sets hotplug=0? This also 
> >>use wrong values if the VM is migrated? 
> 
> I manage this inside deviceplug|unplug. 
> (I remove the pending device at the end) 
> 
> 
> sub vm_deviceplug { 
> .... 
> return 1 if !$conf->{hotplug}; 
> ... 
> #delete pending device after hotplug 
> if($conf->{pending}->{$deviceid}){ 
> $conf->{$deviceid} = $optvalue; 
> delete $conf->{pending}->{$deviceid}; 
> PVE::QemuServer::update_config_nolock($vmid, $conf, 1); 
> } 
> } 

What is someone wants: 

hotplug: 0 

Then you want to keep changes in [PENDING], without applying them.