[pve-devel] [PATCH 2/6] vmconfig_hotplug_pending : add update_net
Dietmar Maurer
dietmar at proxmox.com
Mon Nov 17 17:08:47 CET 2014
> > >>THis looks also problematic. What if someone sets hotplug=0? This
> > >>also use wrong values if the VM is migrated?
> >
> > I manage this inside deviceplug|unplug.
> > (I remove the pending device at the end)
> >
> >
> > sub vm_deviceplug {
> > ....
> > return 1 if !$conf->{hotplug};
> > ...
> > #delete pending device after hotplug
> > if($conf->{pending}->{$deviceid}){
> > $conf->{$deviceid} = $optvalue;
> > delete $conf->{pending}->{$deviceid};
> > PVE::QemuServer::update_config_nolock($vmid, $conf, 1);
> > }
> > }
>
> What is someone wants:
>
> hotplug: 0
>
> Then you want to keep changes in [PENDING], without applying them.
Note: you always use the value from [PENDING] inside pve-bridge
More information about the pve-devel
mailing list