[pve-devel] [PATCH 2/6] vmconfig_hotplug_pending : add update_net

[Alexandre DERUMIER]

>>is this intentional?

Yes, that's why I have add a comment.

We can change some values (disk throttle, disk backups, nic vlan,....) even if we don't have hotplug enabled.



----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Lundi 17 Novembre 2014 16:50:42 
Objet: RE: [pve-devel] [PATCH 2/6] vmconfig_hotplug_pending : add update_net 

> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 141a21c..b948de8 
> 100644 
> --- a/PVE/QemuServer.pm 
> +++ b/PVE/QemuServer.pm 
> @@ -3521,12 +3521,18 @@ sub vmconfig_hotplug_pending { 
> $conf = load_config($vmid); # update/reload 
> } 
> 
> - return if !$conf->{hotplug}; 
> + #return if !$conf->{hotplug}; #some changes can't be done also 
> + without hotplug 

is this intentional?