[pve-devel] qemu-server : implement pending changes v2

[Alexandre DERUMIER]

>>Can't we simply display the changed/new config, and return a 'diff' to show 
>>what is changed. 

mmm,I really don't like this idea. I think it'll confuse user.

I think we should display the running config.

For example if user hot-unplug a disk, and it's failing, we should keep displaying it in config,
if user want to retry to unplug it again.


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 17 Novembre 2014 09:06:04 
Objet: RE: [pve-devel] qemu-server : implement pending changes v2 

Can't we simply display the changed/new config, and return a 'diff' to show 
what is changed. 

Basically we do the same thing with network configuration. 

What do you think? 

> For pending update: 
> 
> [CONF] 
> virtio0: 
> [PENDING] 
> virtio0: 
> 
> 
> display the value "virtio0: old value (pending: new value)" 
> 
> 
> 
> 
> For pending add: 
> [CONF] 
> [PENDING] 
> virtio0: 
> 
> display the value "virtio0:(pending: new value)" 
> 
> 
> 
> 
> 
> for pending delete: 
> 
> [CONF] 
> virtio0: 
> [PENDING] 
> delete: virtio0,.... 
> 
> 
> here,I'm not sure. 
> we could add a new line "pending delete: virtio0,... 
> or display near the current value 
> "virtio0: old value (pending: delete)" 
> 
> but in this case, 
> 
> I don't know how to display 
> 
> [CONF] 
> virtio0:oldvalue 
> [PENDING] 
> virtio0: newvalue 
> delete: virtio0 
> 
> 
> "virtio0: old value (pending: delete - new value)" ? 
> 
> 
> 
> 
> 
> 
> 
> 
> ----- Mail original ----- 
> 
> De: "Dietmar Maurer" <dietmar at proxmox.com> 
> À: "Alexandre DERUMIER" <aderumier at odiso.com>, pve- 
> devel at pve.proxmox.com 
> Envoyé: Lundi 17 Novembre 2014 08:33:40 
> Objet: RE: [pve-devel] qemu-server : implement pending changes v2 
> 
> Do you already have an idea how to implement the GUI? 
> 
> > -----Original Message----- 
> > From: Dietmar Maurer 
> > Sent: Montag, 17. November 2014 08:25 
> > To: 'Alexandre DERUMIER' 
> > Subject: RE: [pve-devel] qemu-server : implement pending changes v2 
> > 
> > > (Do you think I can already work on gui for this ? ) 
> > 
> > sure.