[pve-devel] [PATCH] bugfix : allow multiples venet0 ip in 1 container

[Alexandre DERUMIER]

>>applied, but I wonder If we should match against '\s+' instead?

Yes, indeed it's possible to defined manually in vmid.conf, ips list with multiple space.

----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Mardi 13 Mai 2014 14:42:03 
Objet: RE: [pve-devel] [PATCH] bugfix : allow multiples venet0 ip in 1 container 

applied, but I wonder If we should match against '\s+' instead? 

> + $ip =~ s/\s+/,/g; 

> -----Original Message----- 
> From: pve-devel [mailto:pve-devel-bounces at pve.proxmox.com] On Behalf 
> Of Alexandre Derumier 
> Sent: Dienstag, 13. Mai 2014 10:19 
> To: pve-devel at pve.proxmox.com 
> Subject: [pve-devel] [PATCH] bugfix : allow multiples venet0 ip in 1 container 
> 
> 
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com> 
> --- 
> src/PVE/Firewall.pm | 1 + 
> 1 file changed, 1 insertion(+) 
> 
> diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 
> 4cefc41..803bebf 100644 
> --- a/src/PVE/Firewall.pm 
> +++ b/src/PVE/Firewall.pm 
> @@ -2614,6 +2614,7 @@ sub compile { 
> 
> if ($conf->{ip_address} && $conf->{ip_address}->{value}) { 
> my $ip = $conf->{ip_address}->{value}; 
> + $ip =~ s/\s/,/g; 
> generate_venet_rules_direction($ruleset, $cluster_conf, 
> $hostfw_conf, $vmfw_conf, $vmid, $ip, 'IN'); 
> generate_venet_rules_direction($ruleset, $cluster_conf, 
> $hostfw_conf, $vmfw_conf, $vmid, $ip, 'OUT'); 
> } 
> -- 
> 1.7.10.4 
> 
> _______________________________________________ 
> pve-devel mailing list 
> pve-devel at pve.proxmox.com 
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel