[pve-devel] [PATCH 2/3] add firewall bridge support for openvswitch

[Alexandre DERUMIER]

>>I wonder if we really need that code - can't we query /etc/network/interfaces for
>>that instead?

It was to be sure to have the running config, but we can read /etc/network/interfaces if you want, no problem.

It's just a check to be sure that's a ovs switch.
(don't known if they are another way to check it)


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Mercredi 7 Mai 2014 17:21:11 
Objet: RE: [pve-devel] [PATCH 2/3] add firewall bridge support for openvswitch 

> + my $bridge_hash = {}; 
> + 
> + eval { $bridge_hash = read_openvswitch_config() }; 
> + 
> + die "$bridge is not an linux bridge or openvswitch switch" if 
> !$bridge_hash->{$bridge}; 

I wonder if we really need that code - can't we query /etc/network/interfaces for 
that instead?