[pve-devel] [PATCH 1/2] This patch refactors ZFS's LUN management code, removing the existing LunCmds implementations, in favor of a single lun management infraestructure which just invokes a 'management helper' (which can be either an script or a nat

[Pablo Ruiz]

Well I was thinking on passing some discriminator value which can be used by the script to difference in case of multiple callers using different zpools. (on my own test cluster I have setup a couple of storages/zpools).

However, specifying the pool would be a valid discriminator too, alas it will be more usefull than storage'a name.

Regarding the rest of cfg values. I've just remembered why I was passing them all.. If the blocksize was defined (ie. as 4k) at storage.cfg. The iscsi server needs to know about such value at LUN creation/sharing time.
However one can set this value at scripts' settings, as we concluded earlier.. Just a bit more of a bourden as there may appear more duplicated settings in the future.

Regards

Sent from my iPhone

On 20 Mar 2014, at 10:56, Dietmar Maurer <dietmar at proxmox.com> wrote:

>> Humm, that makes a lot of sense. ;)
>> I will pass the storage's name/id as anotjer PMXVAR, and remove all PMXCFG
> 
> IMHO  the storage name is PVE specific. The Storage server should not know that.
> 
> Instead, you should pass $scfg->{pool} ? 
>