[pve-devel] [PATCH 1/2] This patch refactors ZFS's LUN management code, removing the existing LunCmds implementations, in favor of a single lun management infraestructure which just invokes a 'management helper' (which can be either an script or a nat

[Pablo Ruiz]

Humm, that makes a lot of sense. ;)

I will pass the storage's name/id as anotjer PMXVAR, and remove all PMXCFG
variables, this way we will produce a much shorter command string.
On Mar 20, 2014 7:30 AM, "Dietmar Maurer" <dietmar at proxmox.com> wrote:

> > > Just curious - how long are the command lines this patch generates?
> > Well, it looks like that depends on a number of things.  The entire
> contents of
> > %$scfg are added to the environment as PMXCFG_*, the full path to the ssh
> > key is added to the environment as PMXVAR_SSHKEY (and then added again
> > as an argument to ssh, if ssh is used), and depending on the command
> being
> > issued, you either get PMXVAR_LUNDEV or PMXVAR_LUNUUID, set to the
> > appropriate value.  So potentially quite long - certainly longer than I
> expected
> > on my first glance through the code.
>
> I think you should not pass any configuration from Proxmox to ZFS server.
> Instead,
> the script on the ZFS server side should have its own configuration file.
>
> What do you think about that?
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20140320/02006131/attachment.htm>