[pve-devel] [PATCH] enable q35 machine support

[Alexandre DERUMIER]

>>Previously, we only created usb devices if the VM uses usb devices. Why did you change that? 

the q35 chipset support native usb2,
and as it's a new model, I think the good time to enable by default some controllers.


this can be usefull to enable usb passthrough device hotplug for example.


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Mercredi 18 Juin 2014 06:19:35 
Objet: RE: [pve-devel] [PATCH] enable q35 machine support 

> - $pciaddr = print_pci_addr("piix3", $bridges); 
> - push @$devices, '-device', "piix3-usb-uhci,id=uhci$pciaddr.0x2"; 
> + if($q35){ 
> + push @$devices, '-readconfig', '/usr/share/qemu-server/pve-q35.cfg'; 
> + }else{ 
> + $pciaddr = print_pci_addr("piix3", $bridges); 
> + push @$devices, '-device', 
> + "piix3-usb-uhci,id=uhci$pciaddr.0x2"; 
> 
> - my $use_usb2 = 0; 
> - for (my $i = 0; $i < $MAX_USB_DEVICES; $i++) { 
> - next if !$conf->{"usb$i"}; 
> - $use_usb2 = 1; 
> + my $use_usb2 = 0; 
> + for (my $i = 0; $i < $MAX_USB_DEVICES; $i++) { 
> + next if !$conf->{"usb$i"}; 
> + $use_usb2 = 1; 
> + } 
> + # include usb device config 
> + push @$devices, '-readconfig', 
> + '/usr/share/qemu-server/pve-usb.cfg' if $use_usb2; 
> } 
> - # include usb device config 
> - push @$devices, '-readconfig', '/usr/share/qemu-server/pve-usb.cfg' if 
> $use_usb2; 

Previously, we only created usb devices if the VM uses usb devices. Why did you change that?