[pve-devel] saving kvm command line for migration

[Alexandre DERUMIER]

>>but what about hot plugging cpus? I'm already working on hot plugging
>>memory.
>>
>>So not allowing to modify will fail for hot plug memory and hot plug
>>cpu. These two will become very important the next years or even month.


>>B. Do not allow to modify the configuration while the VM is running (and hotplug disabled)

I think that dietmar want to say, no allowing to change the config file (through api) when vm is online,
only for values which cannot be change online or not hotplug. (like maxcpu, cpumodel,change disk if hotplug is disabled... for example)

(I think this could also avoid some messages in the forum like : "I have change a value, do a reset of the vm, and I don't see the new value"
 If we force to change them offline (non hotplug values), it'll work when the vm will start)

>>A. store the configuration at VM start (and use that configuration to start after migration)
I think it's also more complex, because you need to manage 2 configuration, if you hotplug something, you need to update vmstart config and current config.


----- Mail original ----- 

De: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag> 
À: "Dietmar Maurer" <dietmar at proxmox.com>, pve-devel at pve.proxmox.com 
Envoyé: Mercredi 19 Février 2014 12:51:37 
Objet: Re: [pve-devel] saving kvm command line for migration 


Am 19.02.2014 12:24, schrieb Dietmar Maurer: 
>> B.) is to unflexible. 
> 
> I think this is good enough. 

but what about hot plugging cpus? I'm already working on hot plugging 
memory. 

So not allowing to modify will fail for hot plug memory and hot plug 
cpu. These two will become very important the next years or even month. 

>> Even it might be easier to implement. 
> 
> Note: much, much, much easier to implement ;-) 

mhm i don't see a real problem but may be i'm missing something. 

>> We have the same problem for snapshots. 
> 
> Why? We save the configuration for snapshots, so this is OK. 
> 
>> We just save the config and HOPE that the newly 
>> generated command line matches the old one. 
> 
> No, we do not hope that. Instead, it is perfectly valid that the command lines differ! 


Stefan 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel