[pve-devel] [PATCH 2/7] Storage Plugins: extend clone_image by snap parameter and add support to RBDPlugin

Dietmar Maurer dietmar at proxmox.com
Fri Feb 7 16:15:53 CET 2014


> >>>
> >>> "if $snapname" should be enough.
> >>
> >> If $snapname is "0mysnap" it isn't as perl would interpret this as
> >> false
> >
> > I don't really remember, but normally our names are not allowed to start with
> numbers.
> > No sure if we have that restrictions for snapshot names.
> 
> I just thought it's safer and doesn't hurt. Also it does not give any warnings for
> undef values - so it's a pretty good way to check for valid values in those cases.

Ok (I was not aware of that behavior).


More information about the pve-devel mailing list