[pve-devel] [PATCH] always list copy and clone for cloning

[Alexandre DERUMIER]

>>Yes this is already implented through an ajax call in GUI which disabled 
>>the 'clone' button.
Oh,ok perfect :)


----- Mail original ----- 

De: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Vendredi 7 Février 2014 09:33:51 
Objet: Re: [pve-devel] [PATCH] always list copy and clone for cloning 

Am 07.02.2014 09:32, schrieb Alexandre DERUMIER: 
> cloning from snapshot is not possible for qcow2 files. 
> 
> we need to check if feature is available in storage plugin. 

Yes this is already implented through an ajax call in GUI which disabled 
the 'clone' button. 

Stefan 

> (through api vm_feature) 
> 
> ----- Mail original ----- 
> 
> De: "Stefan Priebe" <s.priebe at profihost.ag> 
> À: pve-devel at pve.proxmox.com 
> Envoyé: Jeudi 6 Février 2014 14:04:48 
> Objet: [pve-devel] [PATCH] always list copy and clone for cloning 
> 
> 
> Signed-off-by: Stefan Priebe <s.priebe at profihost.ag> 
> --- 
> www/manager/qemu/Clone.js | 5 +---- 
> 1 file changed, 1 insertion(+), 4 deletions(-) 
> 
> diff --git a/www/manager/qemu/Clone.js b/www/manager/qemu/Clone.js 
> index 3409c85..28d9a1f 100644 
> --- a/www/manager/qemu/Clone.js 
> +++ b/www/manager/qemu/Clone.js 
> @@ -137,10 +137,7 @@ Ext.define('PVE.window.Clone', { 
> 
> col1.push(me.targetSel); 
> 
> - var modelist = [['copy', gettext('Full Clone')]]; 
> - if (me.isTemplate) { 
> - modelist.push(['clone', gettext('Linked Clone')]); 
> - } 
> + var modelist = [['copy', gettext('Full Clone')], ['clone', gettext('Linked Clone')]]; 
> 
> me.kv1 = Ext.create('PVE.form.KVComboBox', { 
> fieldLabel: gettext('Mode'), 
>