[pve-devel] [PATCH 2/3] API2: remove require full parameter for snapshot cloning

[Alexandre DERUMIER]

Thanks for the patch stefan, I'll try them next week.

about this patch,

>>- if ($param->{full} || !PVE::Storage::volume_is_base($storecfg, $drive->{file})) { 
>>+ if ($param->{full}) { 
>>die "Full clone feature is not available" 
>>if !PVE::Storage::volume_has_feature($storecfg, 'copy', $drive->{file}, $snapname, $running); 
>>$drive->{full} = 1; 
-- 

we need to add a check if cloning feature from snapshot is available in the storage plugin


PVE::Storage::volume_has_feature($storecfg, 'clone', $drive->{file}, $snapname, $running);

----- Mail original ----- 

De: "Stefan Priebe" <s.priebe at profihost.ag> 
À: pve-devel at pve.proxmox.com 
Envoyé: Jeudi 6 Février 2014 14:04:51 
Objet: [pve-devel] [PATCH 2/3] API2: remove require full parameter for snapshot cloning 


Signed-off-by: Stefan Priebe <s.priebe at profihost.ag> 
--- 
PVE/API2/Qemu.pm | 3 +-- 
1 file changed, 1 insertion(+), 2 deletions(-) 

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm 
index abbf068..69bea95 100644 
--- a/PVE/API2/Qemu.pm 
+++ b/PVE/API2/Qemu.pm 
@@ -2057,7 +2057,6 @@ __PACKAGE__->register_method({ 
description => "Add the new VM to the specified pool.", 
}, 
snapname => get_standard_option('pve-snapshot-name', { 
- requires => 'full', 
optional => 1, 
}), 
storage => get_standard_option('pve-storage-id', { 
@@ -2191,7 +2190,7 @@ __PACKAGE__->register_method({ 
if (PVE::QemuServer::drive_is_cdrom($drive)) { 
$newconf->{$opt} = $value; # simply copy configuration 
} else { 
- if ($param->{full} || !PVE::Storage::volume_is_base($storecfg, $drive->{file})) { 
+ if ($param->{full}) { 
die "Full clone feature is not available" 
if !PVE::Storage::volume_has_feature($storecfg, 'copy', $drive->{file}, $snapname, $running); 
$drive->{full} = 1; 
-- 
1.7.10.4 

_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel