[pve-devel] backup lock

[Lindsay Mathieson]

On Wed, 24 Dec 2014 01:53:40 PM Dietmar Maurer wrote:
> > On Wed, 24 Dec 2014 11:57:52 AM Dietmar Maurer wrote:
> > > On power failure, it is impossible to remove the lock, because we are
> > > already dead.
> > > I guess we should remove that lock when we start a node.
> > >
> > > 
> > >
> > > But this bug is about removing the lock after receiving a signal (TERM).
> >
> > 
> >
> > Ah yes, I see your point.
> >
> > 
> >
> > We have a UPS and I thought it signalled a proper shutdown, but  I'm not
> > sure  - I'll try a test.
> 
> Ah, and this is one more case  I guess we should terminate all backup
> tasks at shutdown (what about other tasks like storage migrate?


I suspect all tasks should be cleanly killed if possible

> 
> AFAIK this is currently not implemented.

Yup :) Just finished my test:


- Scheduled a backup on a node with a autostart VM, 

- rebooted the node when it was backing up the VM

- VM shutdown failed with a lock error. That is quite a problem, as the VM is then killed.

- Autostart failed with a lock error.


- Manual start of the VM fails with a locked error.

- After unlock, all is ok.


A clean terminate of the backup and unlock of the currently backing up VM is needed.

cheers,

-- 
Lindsay Mathieson 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20141224/810b37af/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20141224/810b37af/attachment.sig>