[pve-devel] [PATCH] this commit:

Dietmar Maurer dietmar at proxmox.com
Mon Dec 22 16:36:50 CET 2014


>  	$timeout = 60 if !defined($timeout);
> -	my $config = load_config($vmid);

Oh, we already have $conf loaded - good catch!

>  	eval {
>  	    if ($shutdown) {
> -		if ($config->{agent}) {
> +		if (!$nocheck && $conf->{agent}) {
>  		    vm_qmp_command($vmid, { execute => "guest-shutdown" }, $nocheck);

we pass $nockeck to  vm_qmp_command, so the following should be good enough:

-		if ($config->{agent}) {
+		if ($conf->{agent}) {


Would you mind to cleanup the patch? Or can I simply commit a modified version?




More information about the pve-devel mailing list