[pve-devel] [PATCH] pending grid demo

[Alexandre DERUMIER]

>>- current widget dynamically updates content (UpdateStore) 
Yes, I don't now how it's working exactly.

>>- now way to edit configs when they do not exist(for example Display or 
>>CPU settings) 

Yes, I don't known how to do it. With config api, it's managed in jsonreader


>>- Option Tab is still using old config API? 
No, It's using pengind api

diff --git a/www/manager/qemu/Options.js b/www/manager/qemu/Options.js
index 490c475..7cd302f 100644
--- a/www/manager/qemu/Options.js
+++ b/www/manager/qemu/Options.js

        Ext.applyIf(me, {
-           url: "/api2/json/nodes/" + nodename + "/qemu/" + vmid + "/config",
+           url: "/api2/json/nodes/" + nodename + "/qemu/" + vmid + "/pending",
            cwidth1: 170,
            tbar: [ edit_btn ],
            rows: rows,
-- 



>>Also, using 3 columns reduces available space, so I am not 100% sure 
>>this is the best solution. 
>>
yes, I can be a problem with disk for example (with clones parent chains, this can be long string)



>>- Maybe we can simply use 2 lines per setting? 

I think for options for example, we don't need a new line by default

maybe, something like:
http://loianegroner.com/2012/05/extjs-4-example-multiline-row-in-a-grid/


Only create a second line in the cell, if not enough space to display it only

example of big line:
---------------------
column1   column2

virtio0   local:100/vm-100-disk-1.raw,format=raw,discard=on,............. (pending:local:100/vm-100-disk-1.raw,format=raw,discard=off)

if display resolution is too small
----------------------------------
column1   column2

virtio0   local:100/vm-100-disk-1.raw,format=raw,discard=on,............. 
          (pending:local:100/vm-100-disk-1.raw,format=raw,discard=off)







>>- Or only show the new setting, and use tooltip/hover to display old values? 

I don't like to much this one,I think we should display current value primary

>>- Or use Grid grouping feature (extra group for pending values)? 
I'm reading some examples, I'm not sure how to display that in current grid.

>>For pending delete, maybe use an extra CSS style to make deleted options? 

maybe with text-decoration: line-through;  ? 



----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mardi 16 Décembre 2014 10:16:29
Objet: Re: [pve-devel] [PATCH] pending grid demo

Just tested a bit, and I see some missing functionality: 

- current widget dynamically updates content (UpdateStore) 
- now way to edit configs when they do not exist(for example Display or 
CPU settings) 
- Option Tab is still using old config API? 

Also, using 3 columns reduces available space, so I am not 100% sure 
this is the best solution. 

- Maybe we can simply use 2 lines per setting? 

- Or only show the new setting, and use tooltip/hover to display old values? 

- Or use Grid grouping feature (extra group for pending values)? 

For pending delete, maybe use an extra CSS style to make deleted options?