[pve-devel] Question to code

[Alexandre DERUMIER]

>>I thought that should be: 
>>$save_vmstate = 0 if !$snap->{vmstate};
>>$freezefs = 0 if $snap->{vmstate};

Yes, indeed !


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com>, "Wolfgang" <wolfgang at linksystems.org> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Mardi 2 Décembre 2014 16:51:35 
Objet: RE: [pve-devel] Question to code 

> >>my opinion is you freeze the fs and have a consistent backup, it doesn't matter 
> if with or without ram? 
> 
> When we backup the ram, the vm is going to pause mode, so no disk access and 
> no need to freeze the fs. 

Sounds reasonable, but the current code implements the opposite? 

4883 $freezefs = $save_vmstate = 0 if !$snap->{vmstate}; # vm is not running 

I thought that should be: 

$save_vmstate = 0 if !$snap->{vmstate}; 
$freezefs = 0 if $snap->{vmstate}; 

? 

> (BTW, $freezefs don't do anything currently, we need to implement qga 
> command, feel free to add them ;) 

https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=65994ad73caa33443c68c3d7174ca648362df990