[pve-devel] [PATCH] don't try to hotplug disk if a disk already exist.

[Dietmar Maurer]

what about this:

    } else { # hotplug new disks
+ 	die "some useful error mesage" if $old_volid;
	die "error hotplug $opt" if !PVE::QemuServer::vm_deviceplug($storecfg, $conf, $vmid, $opt, $drive);
    }
}

> -----Original Message-----
> From: Alexandre DERUMIER [mailto:aderumier at odiso.com]
> Sent: Freitag, 29. August 2014 09:25
> To: Dietmar Maurer
> Cc: pve-devel at pve.proxmox.com
> Subject: Re: [pve-devel] [PATCH] don't try to hotplug disk if a disk already exist.
> 
> >>This does not display any errors if $old_volid is set?
> >>I think we should raise an error to indicate that something went wrong?
> 
> 
> 
> 
> Maybe
> 
> elsif (!$old_volid) { # hotplug new disks
>    die "error hotplug $opt" if !PVE::QemuServer::vm_deviceplug($storecfg,
> $conf, $vmid, $opt, $drive);
> 
> }elseif ($old_voldid && $old_voldid ne $new_volid {
>   raise an error ?
> }
> 
> 
> ?
> 
> ----- Mail original -----
> 
> De: "Dietmar Maurer" <dietmar at proxmox.com>
> À: "Alexandre Derumier" <aderumier at odiso.com>, pve-
> devel at pve.proxmox.com
> Envoyé: Vendredi 29 Août 2014 08:29:00
> Objet: RE: [pve-devel] [PATCH] don't try to hotplug disk if a disk already exist.
> 
> > - } else { # hotplug new disks
> > -
> > + } elsif (!$old_volid) { # hotplug new disks
> > die "error hotplug $opt" if !PVE::QemuServer::vm_deviceplug($storecfg,
> > $conf, $vmid, $opt, $drive);
> > }
> 
> This does not display any errors if $old_volid is set?
> I think we should raise an error to indicate that something went wrong?