[pve-devel] [PATCH] vmstate snapshot : do no write machine to running config

Dietmar Maurer dietmar at proxmox.com
Fri Aug 29 08:58:35 CEST 2014


> Currently,if we don't have a "machine" option in running config, and we take a
> vmstate snapshot
> 
> the machine option is write in the snapshot (ok), but also in the running config
> (bad)

Yes, we should fix this when we create a snapshot.

But your patch also affect rollback, where we have special code to restore machine config.

For example, in snapshot_rollback(),$forcemachine is wrong because you do not copy machine
config with snapshot_apply_config() ....

or do I miss something?



More information about the pve-devel mailing list