[pve-devel] [PATCH 2/2] setup DHCP server at vm_start

[Dietmar Maurer]

> + # fixme: howto pass gateway for that pool
> --dhcp-option='option:router,192.168.2.1'
> 
> + # fixme: howto pass additional dhcp options
> +
> --dhcp-option='option:optionnumber,optionvalue'

Sure, but where to get that settings? I guess we need to extend the IPPool
to include that information.

> I'm thinking if restarting the dnsmasq daemon at each vm start is good ?
> (what happen if multiple vm stop/start at same time, can we loose some
> dhcp requests?)

Well, we need to add some lock to avoid parallel restarts.

But I think it dfoes not matter if we lose a few request (client retries anyways)?

> Maybe can we restart it only if ressources changes (ip pool, range).

We can do a diff to see if anything has changed.

> and use dhcp-script option to give leases without need to restart daemon ?

I would like to avoid any additional complexity (restart is quite easy), unless we run
into a real problem.

Also, how does 'dhcp-script' option helps here?