[pve-devel] [PATCH] Change iscsi provider to drop-down box Available isci providers are listed in a drop-down box for the user to choose. Fix some indentation problems as well.

Dietmar Maurer dietmar at proxmox.com
Thu Oct 24 07:57:36 CEST 2013


> > >      onGetValues: function(values) {
> > > -	var me = this;
> > > +    var me = this;
> > >
> > > -	if (me.create) {
> > > -	    values.type = 'zfs';
> > > -	    values.content = 'images';
> > > -	} else {
> > > -	    delete values.storage;
> > > -	}
> > > +    if (me.create) {
> > > +        values.type = 'zfs';
> > > +        values.content = 'images';
> > > +    } else {
> > > +        delete values.storage;
> > > +    }
> > >
> > > -	values.disable = values.enable ? 0 : 1;
> > > -	delete values.enable;
> > > +    values.disable = values.enable ? 0 : 1;
> > > +    delete values.enable;
> > >
> > > -	return values;
> > > +    return values;
> > >      },
> >
> > What is that exactly?
> >
> I do not understand your question?

Sorry, I did not read the whole subject.

I would prefer if you send white-space/indentation cleanups using a separate patch. 
Please can you split the patch?




More information about the pve-devel mailing list