[pve-devel] [PATCH] RBD do not hide STDERR

Stefan Priebe - Profihost AG s.priebe at profihost.ag
Fri May 31 11:46:38 CEST 2013


Am 31.05.2013 11:21, schrieb Dietmar Maurer:
>> diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index
>> e147346..cf61ab5 100644
>> --- a/PVE/Storage/RBDPlugin.pm
>> +++ b/PVE/Storage/RBDPlugin.pm
>> @@ -103,7 +103,7 @@ sub rbd_ls {
>>      };
>>
>>      eval {
>> -	run_command($cmd, errmsg => "rbd error", errfunc => sub {},
>> outfunc => $parser);
>> +	run_command($cmd, errmsg => "rbd error", outfunc => $parser);
> 
> Would you mind to explain why that is required? I mean we normally do not expect that
> a normal library call like rdb_ls writes to stderr?

Sorry seems i was a bit too aggressive. I sent a new patch.

Stefan



More information about the pve-devel mailing list