[pve-devel] [PATCH] INotify.pm: Correct read_etc_resolv_conf search filter

damien piquet piqudam at gmail.com
Fri Mar 8 12:38:16 CET 2013


Maybe it would be better to duplicate and keep the first entry? If a
configuration uses it already, we should avoid destroying that
configuration:

#cat /etc/resolv.conf
search domain1.com domain2.com
nameserver 1.2.3.4

would give:

search domain1.com domain2.com
domain domain1.com
nameserver 1.2.3.4

I am not sure this is useful because in most cases search value will
be equal to domain value but we would be sure we don't break anything

2013/3/8 Dietmar Maurer <dietmar at proxmox.com>:
>> That seems a good idea.
>>
>> We should also change the field name in web interface to keep it clear.
>
> yes.
>
> The only problem is how we translate the current configuration? Form what I see,
> current installations have a single domain like:
>
> # cat /etc/resolv.conf
> search test.com
> nameserver 1.2.3.4
>
> I guess we want the following in future:
>
> domain test.com
> nameserver 1.2.3.4
>
> We can automatically translate that if we do not find a domain (using the first search domain entry)?
> Other ideas?
>
>>
>> 2013/3/8 Dietmar Maurer <dietmar at proxmox.com>:
>> >> That's what I think too. We are using search as if it was domain. In
>> >> fact, domain defines the domain the computer is actually on, search
>> >> field defines the domain where to resolve relatives names.
>> >>
>> >> I think we must not use search field when creating ssl certificates !
>> >
>> > yes, only use 'domain'
>> >
>> >> So we need to modify resolv.conf reader. Do we add domain
>> >> modification in web interface?
>> >
>> > yes. Maybe we just replace 'search' with 'domain'? Because 'search' is
>> > not needed most times and will only confuse users?
>


More information about the pve-devel mailing list