[pve-devel] [PATCH] Add dns name format to search value for update_dns method

damien piquet piqudam at gmail.com
Wed Mar 6 18:36:14 CET 2013


That's right. I can't find dns-name-list in JSONSchema. Should we add it ?

2013/3/4 Dietmar Maurer <dietmar at proxmox.com>:
>> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 0dac6af..e35f01b
>> 100644
>> --- a/PVE/API2/Nodes.pm
>> +++ b/PVE/API2/Nodes.pm
>> @@ -610,13 +610,13 @@ __PACKAGE__->register_method({
>>           node => get_standard_option('pve-node'),
>>           search => {
>>               description => "Search domain for host-name lookup.",
>> -             type => 'string',
>> +             type => 'string', format => 'dns-name',
>
> The search domain in resolv-conf is not a simply DNS name. It can be a list of domains.
> Seems our parser in PVE::INotify:: read_etc_resolv_conf() is also wrong.
>
> Not sure how we should handle that. Maybe with:
>
>   type => 'string', format => 'dns-name-list',
>
> And we should fix the parser.
>


More information about the pve-devel mailing list