[pve-devel] Use of uninitialized value in multiplication (*) at /usr/share/perl5/PVE/API2/Qemu.pm line 769

[Alexandre DERUMIER]

Works fine, thanks !


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Mercredi 12 Juin 2013 07:12:05 
Objet: RE: [pve-devel] Use of uninitialized value in multiplication (*) at /usr/share/perl5/PVE/API2/Qemu.pm line 769 

> # qm set 115 -ide1 sheepdog:vm-115-disk-2,mbps_rd=8 update VM 115: - 
> ide1 sheepdog:vm-115-disk-2,mbps_rd=8 Use of uninitialized value in 
> multiplication (*) at /usr/share/perl5/PVE/API2/Qemu.pm line 769. 
> Use of uninitialized value in multiplication (*) at 
> /usr/share/perl5/PVE/API2/Qemu.pm line 769. 
> 
> 
> something is wrong with safe_num_ne, undef values should be 0 

safe_num_ne() is correct - the problem is the later: 

- $drive->{mbps}*1024*1024, 
+($drive->{mbps} || 0)*1024*1024, 

I just uploaded a fix - please can you test?