[pve-devel] update disk config, always rescan all the storage, can we avoid that ?

[Alexandre DERUMIER]

>>This could be also usefull for storage which can take time to create or delete (like rbd with big files), we could create a worker task when add/remove disk. 

I wonder if a generic qm device_add/device_del  could be great ?


qm device_add disk virtio0 ...
qm device_del nic net0

or

qm device_add virtio0 ...
qm device_del net0 ...


cpu hotplug and memory are coming soon, with qom interaction, so having a task could be great too.
(Maybe with a small progress bar like snapshot, as theses action can take some seconds but are not too long)

----- Mail original ----- 

De: "Alexandre DERUMIER" <aderumier at odiso.com> 
À: "Dietmar Maurer" <dietmar at proxmox.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 3 Juin 2013 13:58:06 
Objet: Re: [pve-devel] update disk config, always rescan all the storage, can we avoid that ? 

>>Some time ago I though we can simplify the whole vm_update by restricting the 
>>function to change only a single option (and provide a separate update function 
>>for each option type), but I am not sure. 

Not sure it's easy, because we can update multiple options in 1 api call from gui. (like mbps_rd,mbps_wr,iops_rd,iops_wr,..). 

Maybe it'll be easier to split update and remove/add disk ? 

This could be also usefull for storage which can take time to create or delete (like rbd with big files), we could create a worker task when add/remove disk. 



----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 3 Juin 2013 13:25:04 
Objet: RE: [pve-devel] update disk config, always rescan all the storage, can we avoid that ? 

> >>Yes. But otherwise $settings does not contain drives, so calling 
> >>creat_disks shoukd have no effect? 
> 
> $settings in never empty, as we update the full disk config. 
> 
> example, to update bandwith limit: 
> 
> qm update --virtio0 local:1/vm-1-disk-1,cache=none,size=10G,mbps_rd=10 

ah, got it now - test cases really helps ;-) 

but I have no real idea how to implement that cleanly. 

Some time ago I though we can simplify the whole vm_update by restricting the 
function to change only a single option (and provide a separate update function 
for each option type), but I am not sure. 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel