[pve-devel] [PATCH] fix bug #181: Boot order: twice CDROM gives wrong output

[Alexandre DERUMIER]

>>I don't really understand that fix. The idea was that the user cannot select an option twice. 
Ok I miss that. (But is it really a problem to choose twice the same device ?)


The problem is that if you have

-virtio0
-cdrom

and you choose, cdrom instead virtio0

it's displaying:

-cdrom
-d

because the value of the second combobox is not reset

Maybe can we set value of the second combobox to none ?






----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Mardi 22 Janvier 2013 11:52:56 
Objet: RE: [pve-devel] [PATCH] fix bug #181: Boot order: twice CDROM gives wrong output 

I don't really understand that fix. The idea was that the user cannot select an option twice. 
Your patch seems to remove that property? 

> currently, if we select more than once cdrom or network, first box display 
> correctly, but other display "c" or "n" 
> 
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com> 
> --- 
> www/manager/qemu/BootOrderEdit.js | 8 ++------ 
> 1 file changed, 2 insertions(+), 6 deletions(-) 
> 
> diff --git a/www/manager/qemu/BootOrderEdit.js 
> b/www/manager/qemu/BootOrderEdit.js 
> index a42f330..189dc4a 100644 
> --- a/www/manager/qemu/BootOrderEdit.js 
> +++ b/www/manager/qemu/BootOrderEdit.js 
> @@ -67,12 +67,8 @@ Ext.define('PVE.qemu.BootOrderPanel', { 
> }); 
> } 
> 
> - if (sel1 !== 'd' && (sel2 !== 'd')) { 
> - list.push(['d', 'CD-ROM']); 
> - } 
> - if (sel1 !== 'n' && (sel2 !== 'n')) { 
> - list.push(['n', gettext('Network')]); 
> - } 
> + list.push(['d', 'CD-ROM']); 
> + list.push(['n', gettext('Network')]); 
> //if (sel1 !== 'a' && (sel2 !== 'a')) { 
> // list.push(['a', 'Floppy']); 
> //} 
> -- 
> 1.7.10.4 
> 
> _______________________________________________ 
> pve-devel mailing list 
> pve-devel at pve.proxmox.com 
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel