[pve-devel] adding a new value in rrd ?

[Alexandre DERUMIER]

>>Maybe we can just s/pve2/pve2.3/ as indicator for the new format - we do not need to change anything else 
>>because you don’t' want to store the new value anyways? 

>>I'll try that. (Indeed I don't need to store the the value in the rrds files) 

I think I found a better way (as we don't need new rrds files), just adding 11 blank values before template to not conflict with old values.
Also, for next releases, we 'll have some available values if we need it.

What do you think ?



            $data = "$d->{uptime}:$d->{name}::::::::::::$template:$ctime:$d->{cpus}:$d->{cpu}:" .
                "$d->{maxmem}:$d->{mem}:" .
                "$d->{maxdisk}:$d->{disk}:" .
                "$d->{netin}:$d->{netout}:" .
                "$d->{diskread}:$d->{diskwrite}";


old
----

       $entry->{uptime} = ($d->[0] || 0) + 0;
       $entry->{name} = $d->[1];

       $entry->{maxcpu} = ($d->[3] || 0) + 0;
       $entry->{cpu} = ($d->[4] || 0) + 0;
       $entry->{maxmem} = ($d->[5] || 0) + 0;
       $entry->{mem} = ($d->[6] || 0) + 0;
       $entry->{maxdisk} = ($d->[7] || 0) + 0;
       $entry->{disk} = ($d->[8] || 0) + 0;
       $entry->{netin} = ($d->[9] || 0) + 0;
       $entry->{netout} = ($d->[10] || 0) + 0;
       $entry->{diskread} = ($d->[11] || 0) + 0;
       $entry->{diskwrite} = ($d->[12] || 0) + 0;


new
---

        $entry->{uptime} = ($d->[0] || 0) + 0;
        $entry->{name} = $d->[1];

        $entry->{template} = ($d->[13] || 0) + 0;

        $entry->{maxcpu} = ($d->[15] || 0) + 0;
        $entry->{cpu} = ($d->[16] || 0) + 0;
        $entry->{maxmem} = ($d->[17] || 0) + 0;
        $entry->{mem} = ($d->[18] || 0) + 0;
        $entry->{maxdisk} = ($d->[19] || 0) + 0;
        $entry->{disk} = ($d->[20] || 0) + 0;
        $entry->{netin} = ($d->[21] || 0) + 0;
        $entry->{netout} = ($d->[22] || 0) + 0;
        $entry->{diskread} = ($d->[23] || 0) + 0;
        $entry->{diskwrite} = ($d->[24] || 0) + 0;

----- Mail original ----- 

De: "Alexandre DERUMIER" <aderumier at odiso.com> 
À: "Dietmar Maurer" <dietmar at proxmox.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Dimanche 13 Janvier 2013 16:00:53 
Objet: Re: [pve-devel] adding a new value in rrd ? 

>>Maybe we can just s/pve2/pve2.3/ as indicator for the new format - we do not need to change anything else 
>>because you don’t' want to store the new value anyways? 

I'll try that. (Indeed I don't need to store the the value in the rrds files) 


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Dimanche 13 Janvier 2013 14:38:20 
Objet: RE: [pve-devel] adding a new value in rrd ? 

> Maybe it is better to do a new rrd like you suggest ? (/pve3/xxx=). (But I 
> really only need it in memory) 

Maybe we can just s/pve2/pve2.3/ as indicator for the new format - we do not need to change anything else 
because you don’t' want to store the new value anyways? 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel