[pve-devel] successfull migration but failed resume

[Alexandre DERUMIER]

>>Maybe can we hack qemu, and make the file rename from qemu, at the end of the migration ? 

in migration.c

static void migrate_fd_completed(MigrationState *s)
{
    DPRINTF("setting completed state\n");
    if (migrate_fd_cleanup(s) < 0) {
        s->state = MIG_STATE_ERROR;
    } else {
        s->state = MIG_STATE_COMPLETED;

>>>>> move config file here

        runstate_set(RUN_STATE_POSTMIGRATE);
    }
    notifier_list_notify(&migration_state_notifiers, s);
}




----- Mail original ----- 

De: "Alexandre DERUMIER" <aderumier at odiso.com> 
À: "Michael Rasmussen" <mir at datanom.net> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Samedi 23 Février 2013 12:44:50 
Objet: Re: [pve-devel] successfull migration but failed resume 

I think the main problem is that qemu is doing the switch himself. 
(when all memory is transferred, the source process is paused and the target process continue. 

But we move check the config file, by checking the migration status in a loop with qmp command, with some ms sleep 
So it's possible that the migration is finished some milliseconds before we see it and move the file. 
Also qmp check command could fail. 


Maybe can we hack qemu, and make the file rename from qemu, at the end of the migration ? 
Dietmar, what do you think about this ? 


----- Mail original ----- 

De: "Michael Rasmussen" <mir at datanom.net> 
À: pve-devel at pve.proxmox.com 
Envoyé: Samedi 23 Février 2013 11:21:35 
Objet: Re: [pve-devel] successfull migration but failed resume 

On Sat, 23 Feb 2013 08:05:35 +0100 (CET) 
Alexandre DERUMIER <aderumier at odiso.com> wrote: 

> 
> Ideas are welcome to improve this ;) 
> 
> 
Since it will always be a deal between to nodes you could implement 
something like the TCP 3-way handshake (SYN,SYN-ACK,ACK). 

Node A sends a Migrate SYNchronize packet to Node B 

Node B receives A's SYN 

Node B sends a SYNchronize-ACKnowledgement 

Node A receives B's SYN-ACK 

Node A sends ACKnowledge 

Node B receives ACK. 

Migration is completed. 

-- 
Hilsen/Regards 
Michael Rasmussen 

Get my public GnuPG keys: 
michael <at> rasmussen <dot> cc 
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xD3C9A00E 
mir <at> datanom <dot> net 
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE501F51C 
mir <at> miras <dot> org 
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE3E80917 
-------------------------------------------------------------- 
She's so tough she won't take 'yes' for an answer. 

_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel