[pve-devel] [PATCH] Improved ipv4 addresses validation (sub pve_verify_ipv4 line 139)

[Dietmar Maurer]

> Sent a patch to improve ipv4 validation procedure. Now you can enter ip
> addresses like 10.1.0.0 (final 0 was denied in previous version).
> 
> However, this is a classful validation, a better way to do this would be comparing
> the address with the associated mask.
> 
> Is it possible to send the mask to this function, or should we merge the two
> functions in a new one ?

I guess you need to do those checks inside the API call, where you get both values.
And please use Net::IP if possible.