[pve-devel] [PATCH] don't unplug nic on update

[Dietmar Maurer]

Does this really work when user changes rate or VLAN setting?

> -----Original Message-----
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel-
> bounces at pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Freitag, 22. Februar 2013 06:08
> To: pve-devel at pve.proxmox.com
> Subject: [pve-devel] [PATCH] don't unplug nic on update
> 
> Stefan report an hang if we fast remove/add nic when update.
> 
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>  PVE/API2/Qemu.pm |    5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index ee02467..9321a69
> 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -749,11 +749,6 @@ my $vmconfig_update_disk = sub {  my
> $vmconfig_update_net = sub {
>      my ($rpcenv, $authuser, $conf, $storecfg, $vmid, $opt, $value) = @_;
> 
> -    if ($conf->{$opt}) {
> -	#if online update, then unplug first
> -	die "error hot-unplug $opt for update" if
> !PVE::QemuServer::vm_deviceunplug($vmid, $conf, $opt);
> -    }
> -
>      $conf->{$opt} = $value;
>      PVE::QemuServer::update_config_nolock($vmid, $conf, 1);
>      $conf = PVE::QemuServer::load_config($vmid); # update/reload
> --
> 1.7.10.4
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel