[pve-devel] run_command is not 'thread safe'

[Michael Rasmussen]

On Sun, 11 Aug 2013 04:14:10 +0000
Dietmar Maurer <dietmar at proxmox.com> wrote:

> I don't see the problem, because run_command is synchronous.
> So we always run only one command.
> 
run_command itself is synchronous but the web interface is threaded so
the gui can issue several calls concurrently which all could cause a
call to run_command. This in itself is not the problem. The real
problem is that all of these run_command will all share the same
call-back functions and therefore will all variables in the call-back
functions be shared between all the running instances of run_command.

-- 
Hilsen/Regards
Michael Rasmussen

Get my public GnuPG keys:
michael <at> rasmussen <dot> cc
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xD3C9A00E
mir <at> datanom <dot> net
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE501F51C
mir <at> miras <dot> org
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE3E80917
--------------------------------------------------------------
The best way to get rid of worries is to let them die of neglect.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20130811/358a350b/attachment.sig>