[pve-devel] Copy from snapshot

[Alexandre DERUMIER]

Ah, OK. 

>>So what for is that check in your patches? Can't we always create a full clone from snapshot? 

currently with qemu-img : qcow2,rbd,sheepdog.

But nexenta....it's not possible. (could be done with nexenta with cloning the snapshot then "zfs promote", to detach the clone child from the parent)

Maybe future storage backend will have snapshot but not cloning. (glusterfs ?)

That's why I have added the has_feature check.


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Mardi 30 Avril 2013 10:13:15 
Objet: RE: Copy from snapshot 

> >>It currently requires the "--full" parameter. Do you think we can conditionally 
> clone if the feature is available (else we simply do a full copy)? 
> 
> "Do you think we can conditionally clone" 
> 
> Do you mean linked clone ? 

Yes, 'linked clone'. I will try to use this wording in future. 

> I think only full copy is enough, It'll be difficult to manage the parent-child 
> relationship without base-xxx name. 

Ah, OK. 

So what for is that check in your patches? Can't we always create a full clone from snapshot? 

Or maybe you forgot to pass the $running parameter there? 


+ die "clonemode $clonemode feature is not available" if !PVE::QemuServer::has_feature($clonemode, $parentconf, $storecfg, $snapname);