[pve-devel] [PATCH 1/5] add qemu_img_convert

[Alexandre DERUMIER]

I'll resend an improved version monday


----- Mail original ----- 

De: "Alexandre DERUMIER" <aderumier at odiso.com> 
À: "Dietmar Maurer" <dietmar at proxmox.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Vendredi 26 Avril 2013 13:59:42 
Objet: Re: [pve-devel] [PATCH 1/5] add qemu_img_convert 

>>Why do you suppress messages to stderr, 
No reason, I think we can remove errfunc=> sub {} 

>>and why do we need a $parser here? 
I' don't remember exactly, but I think that without outfunc, run_command display the full output result when finished, and not progressivly. 

also , currently it's only display the raw output of progression % , but maybe can we improve the display (total bytes transferred , remaining bytes) 


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Vendredi 26 Avril 2013 13:36:44 
Objet: RE: [pve-devel] [PATCH 1/5] add qemu_img_convert 

> + my $parser = sub { 
> + my $line = shift; 
> + print $line."\n"; 
> + }; 
> + 
> + eval { run_command($cmd, timeout => undef, errfunc => sub {}, outfunc 
> => $parser); }; 

Why do you suppress messages to stderr, and why do we need a $parser here? 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel