[pve-devel] [PATCH] Nodeselector: change default sort to name instead of mem

Stefan Priebe - Profihost AG s.priebe at profihost.ag
Wed Apr 24 08:13:07 CEST 2013


Yes but to have the sorting correct the value shouldn't be changed in
the render function it must be changed via a converter to a sortable
value and then later the renderer can add % and stuff like that to the
value.

But i think you already know this ;-)

Am 24.04.2013 07:52, schrieb Dietmar Maurer:
> We just need another render function, which display the absolute value
> and the percentage?
> 
>  
> 
> *From:*Alexandre DERUMIER [mailto:aderumier at odiso.com]
> *Sent:* Dienstag, 23. April 2013 18:05
> *To:* Stefan Priebe - Profihost AG
> *Cc:* pve-devel at pve.proxmox.com; Dietmar Maurer
> *Subject:* Re: [pve-devel] [PATCH] Nodeselector: change default sort to
> name instead of mem
> 
>  
> 
> I can confirm that it's not sorting correctly for me too
> 
> here a default sorting migrate
> 
> 
> 
>         
> 
> ------------------------------------------------------------------------
> 
> 
> De: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag
> <mailto:s.priebe at profihost.ag>>
> À: "Dietmar Maurer" <dietmar at proxmox.com <mailto:dietmar at proxmox.com>>
> Cc: pve-devel at pve.proxmox.com <mailto:pve-devel at pve.proxmox.com>
> Envoyé: Mardi 23 Avril 2013 16:10:29
> Objet: Re: [pve-devel] [PATCH] Nodeselector: change default sort to name
> instead of mem
> 
> Hi Dietmar,
> 
> do you have any idea why memory sorting does not work? I tried to solve
> it but i did not find the Problem.
> 
> Stefan
> 
> Am 22.04.2013 11:21, schrieb Stefan Priebe - Profihost AG:
> 
> Am 22.04.2013 11:20, schrieb Dietmar Maurer:
> 
>         So this does not really make sense anymore, because we want to
>         select the
>          last selected node by default?
> 
> 
>      
>      Why is sorting the list and default value connected? To me these
>     are two
>      different things.
>      
> 
> 
>  The first in the list is selected as default (if there is no default).
>  
> 
> 
>  Yes OK but if you want to manually select another one personally me
>  expects to have alphabetical order. If i then want to have the one with
>  lowest memory i can still sort manually. (if it worked can you find the
>  bug?)
>  
>  Stefan
>  
> _______________________________________________
> 
> 
> pve-devel mailing list
> pve-devel at pve.proxmox.com <mailto:pve-devel at pve.proxmox.com>
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 


More information about the pve-devel mailing list