[pve-devel] [PATCH] Nodeselector: change default sort to name instead of mem

Stefan Priebe - Profihost AG s.priebe at profihost.ag
Mon Apr 22 10:58:05 CEST 2013


Am 22.04.2013 10:41, schrieb Dietmar Maurer:
> why?

Maybe just me and personal guess i never understood why it is sorted by
mem (also mem sorting did never worked for me values are "random").

I think an alphabetical order should be default and if someone wants to
sort by mem he could click on mem - but still this needs to be fixed - i
wasn't able to fix it.

Stefan

>> -----Original Message-----
>> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel-
>> bounces at pve.proxmox.com] On Behalf Of Stefan Priebe
>> Sent: Montag, 22. April 2013 10:34
>> To: pve-devel at pve.proxmox.com
>> Subject: [pve-devel] [PATCH] Nodeselector: change default sort to name instead
>> of mem
>>
>>
>> Signed-off-by: Stefan Priebe <s.priebe at profihost.ag>
>> ---
>>  www/manager/form/NodeSelector.js |   12 +++++++-----
>>  1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/www/manager/form/NodeSelector.js
>> b/www/manager/form/NodeSelector.js
>> index 5dc06c3..a472d7f 100644
>> --- a/www/manager/form/NodeSelector.js
>> +++ b/www/manager/form/NodeSelector.js
>> @@ -18,13 +18,13 @@ Ext.define('PVE.form.NodeSelector', {
>>  	    autoDestory: true,
>>  	    sorters: [
>>  		{
>> +		    property : 'node',
>> +		    direction: 'ASC'
>> +		},
>> +		{
>>  		    property : 'mem',
>>  		    direction: 'DESC'
>>  		},
>> -		{
>> -		    property : 'node',
>> -		    direction: 'ASC'
>> -		}
>>  	    ]
>>  	});
>>
>> @@ -37,12 +37,14 @@ Ext.define('PVE.form.NodeSelector', {
>>  		    {
>>  			header: 'Node',
>>  			dataIndex: 'node',
>> +			sortable: true,
>>  			hideable: false,
>>  			flex: 1
>>  		    },
>>  		    {
>>  			header: 'Memory usage',
>>  			renderer: PVE.Utils.render_mem_usage,
>> +			sortable: true,
>>  			width: 100,
>>  			dataIndex: 'mem'
>>  		    },
>> @@ -79,4 +81,4 @@ Ext.define('PVE.form.NodeSelector', {
>>
>>          me.callParent();
>>      }
>> -});
>> \ No newline at end of file
>> +});
>> --
>> 1.7.10.4
>>
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel at pve.proxmox.com
>> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 


More information about the pve-devel mailing list