[pve-devel] [PATCH 3/3] template_create : add template:1 option.

[Alexandre DERUMIER]

Because you tell me that a template can have non-based name disk. (now a template is just a vm with template:1 option)

So we could have template for users with lvm storage or iscsi storage

And theses templates could be use to do only "full clones".


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Vendredi 19 Avril 2013 07:13:59 
Objet: RE: [pve-devel] [PATCH 3/3] template_create : add template:1 option. 

Hi Akexandre, 

I applied part1 and 2, but I do not really understand this one. 

> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm 
> index 7c20f55..1352e24 100644 
> --- a/PVE/QemuServer.pm 
> +++ b/PVE/QemuServer.pm 
> @@ -4448,17 +4448,8 @@ sub template_create { 
> return if $disk && $ds ne $disk; 
> 
> my $volid = $drive->{file}; 
> - die "volume '$volid' does not support template/clone\n" 
> - if !PVE::Storage::volume_has_feature($storecfg, 'template', $volid); 
> - }); 

why do you remove that check?