[pve-devel] Process to submit patches

Stefan Priebe - Profihost AG s.priebe at profihost.ag
Tue Apr 2 07:08:07 CEST 2013


This works best with a vanilla kernel Bit does not with the rhel6 one. I use the same patch locally.

Stefan

Am 02.04.2013 um 00:52 schrieb Andrew Thrift <andrew at networklabs.co.nz>:

> FYI patch is:
> 
> 
> *** Network.pm.orig     2013-04-02 10:19:42.000000000 +1300
> --- Network.pm  2013-04-02 11:41:44.000000000 +1300
> ***************
> *** 122,138 ****
>      #check if we have an only one ethX or bondX interface in the bridge
> 
>      my $iface;
> !     PVE::Tools::dir_glob_foreach($dir, '((eth|bond)\d+)', sub {
>        my ($slave) = @_;
> 
>        die "more then one physical interfaces on bridge '$bridge'\n" if $iface;
> !       $iface = $slave;
> 
>      });
> 
>      die "no physical interface on bridge '$bridge'\n" if !$iface;
> 
> !     my $ifacevlan = "${iface}.$tag";
> 
>      # create vlan on $iface is not already exist
>      if (! -d "/sys/class/net/$ifacevlan") {
> --- 122,138 ----
>      #check if we have an only one ethX or bondX interface in the bridge
> 
>      my $iface;
> !     PVE::Tools::dir_glob_foreach($dir, '((eth|bond)\d+\.?\d+)', sub {
>        my ($slave) = @_;
> 
>        die "more then one physical interfaces on bridge '$bridge'\n" if $iface;
> !       $iface = $bridge;
> 
>      });
> 
>      die "no physical interface on bridge '$bridge'\n" if !$iface;
> 
> !     my $ifacevlan = "${bridge}.$tag";
> 
>      # create vlan on $iface is not already exist
>      if (! -d "/sys/class/net/$ifacevlan") {
> 
> 
> 
> 
> 
> On 4/2/2013 11:27 AM, Andrew Thrift wrote:
>> Hi,
>> 
>> We are wanting to submit a patch to Network.pm to be included upstream.
>> 
>> Our patch changes the way Proxmox dynamically creates vlans allowing for the current model, as well as for QinQ.
>> 
>> Currently it is not possible to do QinQ on Proxmox as when you specify a VLAN in the WebUI, Proxmox checks the parent bridge for a Physical Interface, then creates the vlan sub-if on the Physical Interface and then binds it to a new bridge.
>> 
>> Our patches creates the vlan sub-if on the parent VM bridge, rather than on the parent interface.   This works with both QinQ and non QinQ configurations.
>> 
>> 
>> What is the process to submit our patch ?
>> 
>> 
>> 
>> 
>> Regards,
>> 
>> 
>> 
>> 
>> 
>> Andrew Thrift
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


More information about the pve-devel mailing list