[pve-devel] RRD graphics in webfrontend broken

Alexandre DERUMIER aderumier at odiso.com
Wed Oct 31 10:34:50 CET 2012


Works fine here too !

----- Mail original ----- 

De: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag> 
À: "Dietmar Maurer" <dietmar at proxmox.com> 
Cc: "Alexandre DERUMIER" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Mercredi 31 Octobre 2012 08:47:30 
Objet: Re: [pve-devel] RRD graphics in webfrontend broken 

Am 31.10.2012 07:28, schrieb Dietmar Maurer: 
>> Subject: Re: [pve-devel] RRD graphics in webfrontend broken 
>> 
>> Sorry last patch still contains a bug. The code can rename a .png.tmp file of 
>> another process which has already started to write to that file. 
>> 
>> So we need file locking too. 
> 
> I finally committed a slightly different solution. I simply use RRDs::graphv and 
> avoid to store any data to files. 
> 
> https://git.proxmox.com/?p=pve-cluster.git;a=commitdiff;h=31938ad4b19e5119ea217858443d699e4edf25d3 
> https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=e4a54fb90da1ccf93879aefcb6b066fead3a4ca9 

Great - works fine here. Didn't knew that you already read the file 
elsewhere. I thought it was passed directly to the browser that's why i 
didn't made it your way. 

Thanks for fixing this ugly bug! 

Stefan 



More information about the pve-devel mailing list