[pve-devel] memory leak in PVE/QMPClient.pm

[Alexandre DERUMIER]

I don't see the update pve-manager package in pvetest ...



----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 29 Octobre 2012 12:50:25 
Objet: Re: [pve-devel] memory leak in PVE/QMPClient.pm 

I just uploaded the fixes. The pvetest repository contains all fixes. 

Please can you test? 

> -----Original Message----- 
> From: Stefan Priebe - Profihost AG [mailto:s.priebe at profihost.ag] 
> Sent: Freitag, 26. Oktober 2012 15:34 
> To: Dietmar Maurer 
> Cc: pve-devel at pve.proxmox.com 
> Subject: Re: [pve-devel] memory leak in PVE/QMPClient.pm 
> 
> please read my 2nd mail. This is sadly not enough. As perl things the circ. 
> reference still exists when going out of scope. 
> 
> We habe to mark the self object in mux as weaken. 
> Am 26.10.2012 15:24, schrieb Dietmar Maurer: 
> >> To fix this we need a DESTROY function in QMPClient: 
> >> sub DESTROY { 
> >> my ($self) = @_; 
> >> 
> >> $self->{mux} = undef; 
> >> } 
> >> 
> >> This is enough to remove the circular reference. 
> > 
> > great! thanks for that fix. 
> > 


_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel