[pve-devel] memory leak in PVE/QMPClient.pm

[Dietmar Maurer]

Uploaded a fix.

Please can you test with latest version (pvetest repository)?

> -----Original Message-----
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel-
> bounces at pve.proxmox.com] On Behalf Of Alexandre DERUMIER
> Sent: Montag, 29. Oktober 2012 12:28
> To: pve-devel at pve.proxmox.com
> Subject: Re: [pve-devel] memory leak in PVE/QMPClient.pm
> 
> or maybe this is because of
> 
> pve-common:
> fix bug in read_memory_usage
> https://git.proxmox.com/?p=pve-
> common.git;a=commit;h=845f01b6c46da03f1a31fd808d4bdcd64c893fb9
> 
> So pvestatd didn't restart before because
> PVE::ProcFSTools::read_memory_usage was wrong ? (so it didn't see the leak
> )
> 
> 
> 
> ----- Mail original -----
> 
> De: "Alexandre DERUMIER" <aderumier at odiso.com>
> À: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag>
> Cc: pve-devel at pve.proxmox.com
> Envoyé: Lundi 29 Octobre 2012 12:20:04
> Objet: Re: [pve-devel] memory leak in PVE/QMPClient.pm
> 
> Hi Guys,
> 
> After update my production cluster to proxmox 2.2 Friday, I have all my
> pvestatd daemon down today
> 
> /var/log/daemon.log.1:Oct 25 12:28:05 kvm2 pvestatd[537462]: restarting
> server after 6 cycles to reduce memory usage (free 36720640 bytes)
> /var/log/daemon.log.1:Oct 25 12:28:05 kvm2 pvestatd[537462]: server
> shutdown (restart)
> 
> 
> (last updated was pvetest from about 1-2 month)
> 
> So leak seem to be introduce after.
> 
> 
> 
> ----- Mail original -----
> 
> De: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag>
> À: "Dietmar Maurer" <dietmar at proxmox.com>
> Cc: pve-devel at pve.proxmox.com
> Envoyé: Lundi 29 Octobre 2012 11:01:16
> Objet: Re: [pve-devel] memory leak in PVE/QMPClient.pm
> 
> Am 29.10.2012 10:58, schrieb Dietmar Maurer:
> >> Might be - i haven't tested this. But to provide a clean DESTROY function
> >> doesn't harm ;-)
> >
> > IMHO, adding code which is not really needed make it difficult to
> understand the source.
> 
> ;-) Yes i think weaken should be enough. As there is no cicle reference
> for perl anymore and it destroys both objects.
> 
> Stefan
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel