[pve-devel] [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

Peter Maydell peter.maydell at linaro.org
Wed Nov 21 23:32:49 CET 2012


On 21 November 2012 17:03, Stefan Weil <sw at weilnetz.de> wrote:
> Why do you use int64_t instead of off_t?
> If the value is related to file sizes, off_t would be a good choice.

Looking at the librbd API (which is what the size and ret
values come from), it uses size_t and ssize_t for these.
So I think probably ssize_t is the right type for ret
(and size) in our structs here.

-- PMM



More information about the pve-devel mailing list