[pve-devel] need advise on rbd disk editing/change (die on path not exist)

[Alexandre DERUMIER]

that's was my idea

vdisk_list() call list_images() on each storage module (so rbs_ls for rados).

Maybe Dietmar do you have an opinion on the right way to implement ?



----- Mail original ----- 

De: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag> 
À: "Dietmar Maurer" <dietmar at proxmox.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 18 Juin 2012 10:25:25 
Objet: Re: [pve-devel] need advise on rbd disk editing/change (die on path not exist) 

Am 18.06.2012 10:05, schrieb Dietmar Maurer: 
>> I think we need a path / disk check per storage plugin? So every storage 
>> plugin should do this check on their own. 
> 
> Alexandre suggested: 
> 
>> maybe vdisk_list and check if disk exist ? 
> 
> What is wrong with the suggestion from Alexandre? 
> What would be the advantage having a per plugin method? 

There's nothing wrong but wouldn't it make sense to still check the 
existance of the image via rbd ls? I thought the idea behind this check 
is to verify that the image / path exist. With a check per plugin even 
with rbd we can check if the image file exist. 

Stefan 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 



-- 

-- 




	Alexandre D erumier 
Ingénieur Système 
Fixe : 03 20 68 88 90 
Fax : 03 20 68 90 81 
45 Bvd du Général Leclerc 59100 Roubaix - France 
12 rue Marivaux 75002 Paris - France