[pve-devel] [PATCH] increase migrate_set_downtime only if expected downtime is more than 30 iterations > 0

[Alexandre DERUMIER]

I'm testing your patch.

remaning memory can also stay at 0 at the end (with last qemu git migration patch), so we need to also check that.


also in your patch, what is

+		$migrate_downtimecounter = time();

?

----- Mail original ----- 

De: "Stefan Priebe" <s.priebe at profihost.ag> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com, "Dietmar Maurer" <dietmar at proxmox.com> 
Envoyé: Dimanche 30 Décembre 2012 13:25:40 
Objet: Re: [pve-devel] [PATCH] increase migrate_set_downtime only if expected downtime is more than 30 iterations > 0 

Hi, 

attached a patch. 

Greets, 
Stefan 

Am 30.12.2012 09:39, schrieb Alexandre DERUMIER: 
>>> What about every 15seconds if no progress has happened? How would 
>>> you define progress? 
> 
> Maybe we can check if remaining memory goes up and down. 
> (So it could also works with qemu 1.4 as we dont have expected_downtime value) 
> 
> (if remaining memory > last remaing memory){ 
> counter++ 
> } 
> 
> if(counter == 15){ 
> 
> set_migrate_downtime = migratedowntime + 0.X sec 
> counter = 0; 
> } 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> ----- Mail original ----- 
> 
> De: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag> 
> À: "Dietmar Maurer" <dietmar at proxmox.com> 
> Cc: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
> Envoyé: Dimanche 30 Décembre 2012 09:33:09 
> Objet: Re: [pve-devel] [PATCH] increase migrate_set_downtime only if expected downtime is more than 30 iterations > 0 
> 
> What about every 15seconds if no progress has happened? How would 
> you define progress? 
> 
> I would then start at 0.15s downtime as 
> default or at custom conf value if defined. If no progress happens I would double the value. 
> 
> Stefan 
> 
> Am 30.12.2012 um 06:55 schrieb Dietmar Maurer <dietmar at proxmox.com>: 
> 
>>> i really like that idea instead of having a fixed downtime of 1s. What is about 
>>> starting at 0.5s and then add 0.5s every 15 runs? 
>> 
>> Yes, we can do that, but may "Every 15 runs if we make no progress"? 
>>