[pve-devel] qm migrate : do we really need a -online option ?

[Michael Rasmussen]

On Fri, 24 Aug 2012 16:48:25 +0200 (CEST)
Alexandre DERUMIER <aderumier at odiso.com> wrote:

> 
> in Qemu.pm
> replace
> 
>         if (PVE::QemuServer::check_running($vmid)) {
>             die "cant migrate running VM without --online\n"
>                 if !$param->{online};
>         }
> 
>  by 
> 
>        if (PVE::QemuServer::check_running($vmid)) {
>                     $param->{online} = 1;
>         }

I second that. The same should be done for CT. Personally I have never
been able to figure out why this option has been available?

-- 
Hilsen/Regards
Michael Rasmussen

Get my public GnuPG keys:
michael <at> rasmussen <dot> cc
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xD3C9A00E
mir <at> datanom <dot> net
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE501F51C
mir <at> miras <dot> org
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE3E80917
--------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20120824/0248d867/attachment.sig>