[pve-devel] [PATCH 02/11] change print_drive sub to new device syntax

[Alexandre DERUMIER]

yes, if=none is mandatory , because if not, it mess up with old qemu syntax and put disk like an ide.




qdev-device-use.txt


"
The various old ways to define drives all boil down to the common form

    -drive if=TYPE,index=IDX,bus=BUS,unit=UNIT,HOST-OPTS...

TYPE, BUS and UNIT identify the controller device, which of its buses
to use, and the drive's address on that bus.  Details depend on TYPE.
IDX is an alternative way to specify BUS and UNIT.

In the new way, this becomes something like

   -drive if=none,id=DRIVE-ID,HOST-OPTS...
   -device DEVNAME,drive=DRIVE-ID,DEV-OPTS...
"





----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Derumier Alexandre" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Jeudi 8 Septembre 2011 09:16:10 
Objet: RE: [pve-devel] [PATCH 02/11] change print_drive sub to new device syntax 

do we really need "if=none" here? 

> -----Original Message----- 
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel- 
> bounces at pve.proxmox.com] On Behalf Of Derumier Alexandre 
> Sent: Mittwoch, 07. September 2011 15:35 
> To: pve-devel at pve.proxmox.com 
> Subject: [pve-devel] [PATCH 02/11] change print_drive sub to new device syntax 
> 
> 
> Signed-off-by: Derumier Alexandre <aderumier at odiso.com> 
> --- 
> PVE/QemuServer.pm | 2 +- 
> 1 files changed, 1 insertions(+), 1 deletions(-) 
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 4ca6e48..1d11e6f 
> 100644 
> --- a/PVE/QemuServer.pm 
> +++ b/PVE/QemuServer.pm 
> @@ -868,7 +868,7 @@ sub print_drive_full { 
> 
> my $pathinfo = $path ? "file=$path," : ''; 
> 
> - return "${pathinfo}if=$drive->{interface},index=$drive->{index}$opts"; 
> + return 
> + "${pathinfo}if=none,id=drive-$drive->{interface}$drive->{index}$opts"; 
> } 
> 
> 
> -- 
> 1.7.2.5 
> 
> _______________________________________________ 
> pve-devel mailing list 
> pve-devel at pve.proxmox.com 
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 





-- 

-- 




	
	Alexandre Derumier 
Ingénieur système 
e-mail : aderumier at odiso.com 
Tél : +33 (0)3 20 68 88 90 
Fax : +33 (0)3 20 68 90 81 
45 Bvd du Général Leclerc 
59100 ROUBAIX - FRANCE 













-------------- next part --------------
A non-text attachment was scrubbed...
Name: aderumier.vcf
Type: text/x-vcard
Size: 183 bytes
Desc: not available
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20110908/c48e30d7/attachment.vcf>