[pve-devel] [PATCH] Fix/cleanup disk hotplug

[Alexandre DERUMIER]

>> Or simply disable hotplug in that case.

Yes, i think you are right.. can be tricky if unplug is ok and after plug failed..


>> I thougth hotplug will fail anyways in that case (because root fs is mounted)? 

I have done more test, on unplug, 

If the device_del will fail, the device is always present.
But the drive_del  call before, flush the last writes to disk and then forbid access to drive.
So disk is no more accessible.

So it can be dangerous on root fs.




----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Jeudi 13 Octobre 2011 09:09:18 
Objet: RE: [pve-devel] [PATCH] Fix/cleanup disk hotplug 

> So I can add a check, if a previous disk config exist, then remove and add it. 

Or simply disable hotplug in that case. 

> Also I think to add some security on boot disk (we don't want to hot-remove it) 

I thougth hotplug will fail anyways in that case (because root fs is mounted)? 

- Dietmar 



-- 

-- 




	
	Alexandre Derumier 
Ingénieur système 
e-mail : aderumier at odiso.com 
Tél : +33 (0)3 20 68 88 90 
Fax : +33 (0)3 20 68 90 81 
45 Bvd du Général Leclerc 
59100 ROUBAIX - FRANCE 













-------------- next part --------------
A non-text attachment was scrubbed...
Name: aderumier.vcf
Type: text/x-vcard
Size: 183 bytes
Desc: not available
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20111013/e12750ec/attachment.vcf>