[pve-devel] [PATCH] Fix/cleanup disk hotplug

[Dietmar Maurer]

For example the following command adds a 4GB drive
# qm set 100 -virtio 4

I can now  issues that command again:

# qm set 100 -virtio 4

so this marks the old drive unused, and creates a new image.

- Dietmar

> -----Original Message-----
> From: Alexandre DERUMIER [mailto:aderumier at odiso.com]
> Sent: Donnerstag, 13. Oktober 2011 07:53
> To: Dietmar Maurer
> Cc: pve-devel at pve.proxmox.com
> Subject: Re: [pve-devel] [PATCH] Fix/cleanup disk hotplug
> 
> What do you mean by change a drive? (pve-manager side ?) Change parameters
> of a running drive ? (like cache/image format parameters by exemple ?)
> 
> 
> ----- Mail original -----
> 
> De: "Dietmar Maurer" <dietmar at proxmox.com>
> À: "Derumier Alexandre" <aderumier at odiso.com>, pve-
> devel at pve.proxmox.com
> Envoyé: Jeudi 13 Octobre 2011 07:33:23
> Objet: RE: [pve-devel] [PATCH] Fix/cleanup disk hotplug
> 
> I can see that your patches can handle add/delete, but what happens when you
> change a drive - does that trigger delete followed by add?
> 
> > -----Original Message-----
> > From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel-
> > bounces at pve.proxmox.com] On Behalf Of Derumier Alexandre
> > Sent: Mittwoch, 12. Oktober 2011 12:16
> > To: pve-devel at pve.proxmox.com
> > Subject: [pve-devel] [PATCH] Fix/cleanup disk hotplug
> >
> > - pass $conf to create_disks sub
> > - add some checks on results of
> > "drive_del","drive_add","device_del","device_add"
> > - replace "sleep 2" by iterative sub vm_waitfordevicecleanup
> 
> 
> 
> 
> --
> 
> --
> 
> 
> 
> 
> 
> 	Alexandre Derumier
> Ingénieur système
> e-mail : aderumier at odiso.com
> Tél : +33 (0)3 20 68 88 90
> Fax : +33 (0)3 20 68 90 81
> 45 Bvd du Général Leclerc
> 59100 ROUBAIX - FRANCE
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>